Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment fixes #13

Merged
merged 11 commits into from
Aug 20, 2021
Merged

Deployment fixes #13

merged 11 commits into from
Aug 20, 2021

Conversation

snicki13
Copy link
Member

Some adjustments to the deployment process including variables + documentation

@snicki13 snicki13 enabled auto-merge (squash) July 20, 2021 22:27
@snicki13 snicki13 requested a review from mxsph July 20, 2021 22:28
Copy link
Member

@mxsph mxsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍

However, I would move the docker-compose.yml in the deployment folder to examples/docker-compose/docker-compose.yml.

(Here you should possibly add a README with an explanation of use later, but it is not so urgent for now).

@mxsph
Copy link
Member

mxsph commented Jul 21, 2021

Shouldn't this PR also close ISSUE #12?

@snicki13
Copy link
Member Author

Shouldn't this PR also close ISSUE #12?

unfortunately not. This is a configuration issue with Angular. I will focus on it at a later stage of deployment.

@snicki13 snicki13 requested a review from mxsph August 20, 2021 20:17
@mxsph mxsph disabled auto-merge August 20, 2021 20:22
@mxsph mxsph merged commit bc2332e into master Aug 20, 2021
@mxsph mxsph deleted the deployment_fixes branch August 20, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants