-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment fixes #13
Deployment fixes #13
Conversation
93d0f47
to
37a4232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍
However, I would move the docker-compose.yml
in the deployment
folder to examples/docker-compose/docker-compose.yml
.
(Here you should possibly add a README
with an explanation of use later, but it is not so urgent for now).
Shouldn't this PR also close ISSUE #12? |
…t_fixes # Conflicts: # deployment/docker-compose.yml
unfortunately not. This is a configuration issue with Angular. I will focus on it at a later stage of deployment. |
Some adjustments to the deployment process including variables + documentation