MdePkg/DebugLib: Add null pointer check to CR macro #10591
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
lgao4,
LiuZhiguang001 and
mdkinney
lgao4
reviewed
Jan 7, 2025
MdePkg/Include/Library/DebugLib.h
Outdated
| @@ -657,11 +657,12 @@ UnitTestDebugAssert ( | |||
| **/ | |||
| #if !defined (MDEPKG_NDEBUG) | |||
| #define CR(Record, TYPE, Field, TestSignature) \ | |||
| ((Record == NULL) ? (_ASSERT (CR has Null Pointer), NULL) : \ | |||
There was a problem hiding this comment.
Record may point to zero address.
There was a problem hiding this comment.
Thank you for your comment. The line was added to check if Record is pointing to zero. If Record is pointing to zero, the assertion _ASSERT (CR has Null Pointer) is triggered, and Record (which is NULL) is returned. I have updated the code accordingly. Please review the updated code and provide any suggestions.
There was a problem hiding this comment.
@lgao4 I have updated the code. Could you please review the latest changes?
r1chard-lyu
force-pushed
the
cr-null-pointer-check
branch
from
6c1fef8 to
d2a9618
Compare
- Added a null pointer check in the CR macro. - If Record is NULL, an assertion is triggered. - This change improves the CR by preventing dereferencing of null pointers. REF: tianocore#10510 Signed-off-by: Richard Lyu <[email protected]>
r1chard-lyu
force-pushed
the
cr-null-pointer-check
branch
from
d2a9618 to
7b6f2d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF: #10510
Description
<Include a description of the change and why this change was made.>
<For each item, place an "x" in between
[and]if true. Example:[x](you can also check items in GitHub UI)><Create the PR as a Draft PR if it is only created to run CI checks.>
<Delete lines in <> tags before creating the PR.>
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>