Using std cleanup #CI-only #10602
Closed
Using std cleanup #CI-only #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop some trailing whitespace. Signed-off-by: Dionna Glaze <[email protected]>
C++ does not support C's register keyword. Signed-off-by: Dionna Glaze <[email protected]>
tianocore-assign-reviewers
bot
requested review from
bexcran,
BobCF,
lgao4 and
YuweiChen1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pccts has decades-old coding style that modern compilers have warnings for. This PR removes "using namespace std;" in headers and removes the defensive coding around a 20 year old Microsoft compiler for C header file names.
Conditional compilation directives are removed since all build configurations defined PCCTS_USE_NAMESPACE_STD.
Google's internal linter pointed out these problems and in an effort to reduce the diff from upstream, here you go :)
How This Was Tested
Builds without warnings.
Integration Instructions
Ignore the rude comments that I did not delete.