Produce EFI memory attribute protocol #5939
Merged
+313
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Jul 22, 2024
niruiyu
reviewed
Aug 21, 2024
niruiyu
reviewed
Aug 21, 2024
CrystalLee-77
force-pushed
the
ProduceEfiMemoryAttributeProtocol
branch
from
aa97276 to
51fb29d
Compare
|
Addressed the review comments. Please review again. |
CrystalLee-77
force-pushed
the
ProduceEfiMemoryAttributeProtocol
branch
from
51fb29d to
e0b1a68
Compare
|
@niruiyu I have addressed the review comments. Please review it again. |
CrystalLee-77
force-pushed
the
ProduceEfiMemoryAttributeProtocol
branch
from
e0b1a68 to
bcebeb3
Compare
|
@niruiyu I have addressed the review comments. Please review it again. |
|
Hi @niruiyu Could you let us know if there are any further concerns on this PR |
|
Hi @niruiyu We would like to see the changes in this PR in the upcoming tag. Could you let us know if there are any others concerns to be addressed here. |
kraxel
approved these changes
Nov 1, 2024
|
@jyao1 , have you any comments for this patch? |
|
I have no comments for this change. If UefiCpuPkg maintainer or reviewer agree this change, I would like to merge it. |
Produce the protocol introduced in UEFI v2.10 that permits the caller to manage mapping permissions in the page tables. Cc: Felix Polyudov <[email protected]> Cc: David Hsieh <[email protected]> Cc: James Wang <[email protected]> Signed-off-by: Crystal Lee <[email protected]>
SplitPage may return OUT_OF_RESOURCES if no memory resource to split page entry. ConvertMemoryPageAttributes should also return OUT_OF_RESOURCES instead of override the status to UNSUPPORTED. Then EfiSetMemoryAttributes and EfiClearMemoryAttributes can return correct status of OUT_OF_RESOURCES when requested attributes cannot be applied due to lack of system resource. Cc: Felix Polyudov <[email protected]> Cc: David Hsieh <[email protected]> Cc: James Wang <[email protected]> Signed-off-by: Crystal Lee <[email protected]>
CrystalLee-77
force-pushed
the
ProduceEfiMemoryAttributeProtocol
branch
from
bcebeb3 to
6591f3c
Compare
niruiyu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Produce the EFI memory attribute protocol introduced in UEFI v2.10 that permits the caller to
manage mapping permissions in the page tables.