Add SmmCpuPlatformHookLib IsCpuSyncAlwaysNeeded interface #6557
Conversation
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jiaxinwu,
jyao1,
kraxel,
LiuZhiguang001,
niruiyu,
rahul1-kumar and
td36
sweeaun
changed the title
|
please also refine the commit message according the new name: IsLmceStatusCheckNeeded |
|
use 2 commits in 1 PR for those 2 different packages changes |
sweeaun
changed the title
|
LMCE expands to "Local Machine Check Exception" I assume? The commit messages describes what is changed, but not why this change is needed. Can you please add that information? |
Hi @kraxel, This new interface allow platform specific implementation to check whether the LMCE status check is required. |
jiaxinwu
added
push
sweeaun
changed the title
|
Based on input from @niruiyu, renamed the interface to IsCpuSyncAlwaysNeeded which is more relevant and generic to the code consumer in MP service later. |
This patch adds the IsCpuSyncAlwaysNeeded interface to the SmmCpuPlatformHookLib. This interface will determine whether the first CPU Synchronization should be executed unconditionally when a SMI occurs. If the function returns true, it indicates that there is no need to check the system configuration and status, and the first CPU Synchronization should be executed unconditionally. If the function returns false, it indicates that the first CPU Synchronization is not executed unconditionally, and the decision to synchronize should be based on the system configuration and status. Signed-off-by: Khor Swee Aun <[email protected]>
This patch is to implement default IsCpuSyncAlwaysNeeded definition for SmmCpuPlatformHookLibQemu. This interface will determine whether the first CPU Synchronization should be executed unconditionally when a SMI occurs. If the function returns true, it indicates that there is no need to check the system configuration and status, and the first CPU Synchronization should be executed unconditionally. If the function returns false, it indicates that the first CPU Synchronization is not executed unconditionally, and the decision to synchronize should be based on the system configuration and status. Signed-off-by: Khor Swee Aun <[email protected]>
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Description
Determines whether all CPUs sync is needed.
This function determine if all CPUs needed to be synced unconditional during the 1st APs sync.
By default, it returns FALSE which indicates not all CPUs needed to be synced. In case of all CPUs
needed to be synced, platform specific implementation can return TRUE.
How This Was Tested
No test except compile the code successfully as new interface not being used by other code now. Test can be done once it called by other code later.