Fix handling of bare DATABRICKS_HOST environment variables
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments (e.g. Workbench) set `DATABRICKS_HOST` to the bare hostname and omit the HTTPS prefix; this breaks when we later expect it to be an actual URL. So this commit updates `databricks_workspace()` to handle both cases. Similar code exists in all of the other Databricks packages and SDKs that I am aware of, so this is nothing new; I just missed it. Unit tests are included. Signed-off-by: Aaron Jacobs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments (e.g. Workbench) set
DATABRICKS_HOSTto the bare hostname and omit the HTTPS prefix; this breaks when we later expect it to be an actual URL.So this commit updates
databricks_workspace()to handle both cases. Similar code exists in all of the other Databricks packages and SDKs that I am aware of, so this is nothing new; I just missed it.Unit tests are included.