Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose xseq in stat_smooth() #5466

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5246.

Briefly, the xseq parameter was already available to users but was undocumented. This PR makes xseq a formal argument to stat_smooth(), thereby acknowledging its availability.

R/stat-smooth.R Outdated Show resolved Hide resolved
R/stat-smooth.R Outdated Show resolved Hide resolved
@teunbrand
Copy link
Collaborator Author

Thanks @EvaMaeRey for the suggestions! I've adapted the wording.

@teunbrand teunbrand requested a review from thomasp85 February 23, 2024 10:05
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 50b8cb1 into tidyverse:main Feb 27, 2024
12 checks passed
@teunbrand teunbrand deleted the expose_xseq branch February 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation of xseq for stat_smooth()
3 participants