Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add point filters to remove noise due to reflection #331

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Oct 9, 2024

Description

Filtered noise points due to reflection by ring section filter in Nebula.

Related:

Tests

Before

image
image

After

image
image

@TomohitoAndo TomohitoAndo marked this pull request as draft October 9, 2024 23:11
@TomohitoAndo TomohitoAndo marked this pull request as draft October 9, 2024 23:11
Signed-off-by: Tomohito ANDO <[email protected]>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review October 11, 2024 10:14
@TomohitoAndo
Copy link
Contributor Author

@kotaro-hihara
corp box filterの置き換えが入ったらいらなくなる想定ですが、
センサーキャリブに影響があるので、それまでの暫定として入れたいです。

Copy link

@kotaro-hihara kotaro-hihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後日自分のマルチFOV用のフィルタに合わせて入れます!

@TomohitoAndo TomohitoAndo merged commit 9460e15 into beta/x2_gen2/v0.29.0 Oct 12, 2024
12 of 13 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/filter-noise-points branch October 12, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants