Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the name of velodyne lidar #364

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Jan 6, 2025

This pull request fixes a bug at #361.

How was this PR tested?

Signed-off-by: Shintaro Sakoda <[email protected]>
@Owen-Liuyuxuan
Copy link
Contributor

Thank you so much, this is exactly what I expected. Sorry for creating this bug.

@SakodaShintaro SakodaShintaro marked this pull request as ready for review January 6, 2025 02:33
@SakodaShintaro
Copy link
Contributor Author

@Owen-Liuyuxuan
All tests passed.
Thank you for your quick response!

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@SakodaShintaro SakodaShintaro merged commit 19c7a48 into tier4/universe Jan 6, 2025
11 of 12 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/name_to_check branch January 6, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants