-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xx1_gen2): update XX1 gen2 sensor configurations #365
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Please add type hinting for the python script.
Signed-off-by: Kento Yabuuchi <[email protected]>
Important When I verified this PR in the actual vehicle, I realized that further modifications to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a PR for configuration changes for XX1 Gen2. It modifies the GNSS, LiDAR, and Radar settings for XX1 Gen2.
Note
Other sensor_models are not affected. 👌
Changes to LiDAR
lidar_gen2.yaml
, the max_range values have been updated, and unnecessary parameters have been removed:TIER IV INTERNAL LINK
lidar.launch.py
to set the return_mode toDual
by default.All LiDARs will operate in
Dual (Strongest + Last)
mode.Changes to Radar
radar.launch.xml
to change the topic remapping about twist (twist) and kinematic_state (odometry).(
It was originally remapped on the wrong topic.)Originally some topics were accidentally contaminated.
To resolve this issue, I added
<group>
to separate the scopes and ensure the correct topics are passed.Caution
continental_launch_all_hw.xml
requiresTwistWithCovarianceStamped
as theodometry_input
. 🫠radar_tracks_msgs_converter.launch.xml
requiresOdometry
asinput/odometry
. 🫠Changes to GNSS
Added septentrio_heading_converter.py.
This scripts converts the
atteuler
(attitude in Euler angles) topic output by septentrio_driver toautoware_orientation
.TIER IV INTERNAL LINK
The autoware_orientation topic is required by gnss_poser to specify GNSS orientation.
Removed unnecessary entries from
gnss.launch.xml
mosaic_x5_rover.param.yaml