Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xx1_gen2): update XX1 gen2 sensor configurations #365

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 6, 2025

Description

This is a PR for configuration changes for XX1 Gen2. It modifies the GNSS, LiDAR, and Radar settings for XX1 Gen2.

Note

Other sensor_models are not affected. 👌

Changes to LiDAR

  1. In lidar_gen2.yaml , the max_range values have been updated, and unnecessary parameters have been removed:

TIER IV INTERNAL LINK

lidar name updated max range
top 300m
front_left 80m
front_right 80m
side_left 10m
side_right 10m
  1. Updated lidar.launch.py to set the return_mode to Dual by default.
    All LiDARs will operate in Dual (Strongest + Last) mode.

Changes to Radar

  1. Modified radar.launch.xml to change the topic remapping about twist (twist) and kinematic_state (odometry).

(It was originally remapped on the wrong topic. )
Originally some topics were accidentally contaminated.
To resolve this issue, I added <group> to separate the scopes and ensure the correct topics are passed.

Caution

Changes to GNSS

  1. Added septentrio_heading_converter.py.
    This scripts converts the atteuler (attitude in Euler angles) topic output by septentrio_driver to autoware_orientation.
    TIER IV INTERNAL LINK
    The autoware_orientation topic is required by gnss_poser to specify GNSS orientation.

  2. Removed unnecessary entries from gnss.launch.xml

  • Deleted entries about the u-blox GNSS.
  • Added septentrio_heading_converter.py.
  1. Updated mosaic_x5_rover.param.yaml
  • Configured to output attitude topic.
  • Adjusted the heading offset to accommodate the antenna configuration in XX1 Gen2. TIER IV INTERNAL LINK

@KYabuuchi KYabuuchi changed the title update XX1 gen2 sensor configurations feat(xx1_gen2): update XX1 gen2 sensor configurations Jan 6, 2025
Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi KYabuuchi marked this pull request as ready for review January 6, 2025 06:19
@KYabuuchi KYabuuchi requested review from shmpwk and Ericpotato January 6, 2025 06:19
Signed-off-by: Kento Yabuuchi <[email protected]>
shmpwk
shmpwk previously approved these changes Jan 6, 2025
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Please add type hinting for the python script.

aip_xx1_gen2_launch/launch/radar.launch.xml Show resolved Hide resolved
@shmpwk shmpwk self-requested a review January 6, 2025 07:33
@KYabuuchi
Copy link
Contributor Author

@shmpwk Hi! I added type hint to python script in 533a502

@KYabuuchi
Copy link
Contributor Author

KYabuuchi commented Jan 6, 2025

Important

When I verified this PR in the actual vehicle, I realized that further modifications to radar.launch.xml were necessary. 🙇
I have implemented the additional changes in ca1594c, and updated the PR description accordingly.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KYabuuchi KYabuuchi merged commit e7f1a5c into tier4/universe Jan 7, 2025
9 of 10 checks passed
@KYabuuchi KYabuuchi deleted the feat/xx1_gen2_sensor_config branch January 7, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants