-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta/x2 gen2/v0.29.2 #366
Draft
TomohitoAndo
wants to merge
38
commits into
beta/v0.29.0
Choose a base branch
from
beta/x2_gen2/v0.29.2
base: beta/v0.29.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Beta/x2 gen2/v0.29.2 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add aip_x2_gen2 files Signed-off-by: Tomohito ANDO <[email protected]> * rename for gen2 Signed-off-by: Tomohito ANDO <[email protected]> --------- Signed-off-by: Tomohito ANDO <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
* chore: update dummy diag for sensors Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Tomohito ANDO <[email protected]>
Signed-off-by: Tomohito ANDO <[email protected]>
Signed-off-by: Tomohito ANDO <[email protected]>
* replace asterx sb3 * fix ip address * enable gnss.launch
Signed-off-by: vividf <[email protected]>
Signed-off-by: Tomohito ANDO <[email protected]>
* fix(lidar): update PTP settings for new PTP architecture * fix(lidar): set FoVs to their desired (no added padding for correction) values as Nebula handles this now * chore(lidar): change parameters and node name to nebula/develop versions * fix(nebula_node_container): add multicast_ip parameter * fix(nebula_node_container): add point_filters parameter * hotfix(nebula_container_launch): ring outlier filter segfaults, disable it for now * ci(pre-commit): autofix * feat(common_sensor_launch): add distortion corrector param (#247) * feat: add distortion corrector param Signed-off-by: vividf <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: vividf <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: add parameter for distortion corrector --------- Signed-off-by: vividf <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yi-Hsiang Fang (Vivid) <[email protected]>
* remove duplicated parameter * use pointcloud container var
fix gnss antenna
…_filter (#316) * chore(nebula_node_container): confirm ring outlier filter is working with the latest versions: nebula: develop-eval@81afef9ec1cdc1dae9d39e08e916813baab1fd4c transport_drivers: autowarefoundation/transport_drivers.git@8a93ae022604df8132bd65ab8a599532cf4c0a98 ros2_socketcan: /autowarefoundation/ros2_socketcan.git@2bbdba46ce4177e3076892aa99ede557b4f82446 * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: read LiDAR calibration params from file * fix pre-commit errors Signed-off-by: Tomohito ANDO <[email protected]> * fix pre-commit errors Signed-off-by: Tomohito ANDO <[email protected]> --------- Signed-off-by: Tomohito ANDO <[email protected]>
* fix: pass launch_driver argument Signed-off-by: Tomohito ANDO <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore: change sync angle to be forward Signed-off-by: Tomohito ANDO <[email protected]> * change cut_angle of rear LiDAR Signed-off-by: Tomohito ANDO <[email protected]> --------- Signed-off-by: Tomohito ANDO <[email protected]>
* set point_filters test * fix ring id * add point_filters params * add default point_filter(no reduction) * one third all OT128 * set default no reduction * fix Signed-off-by: Tomohito ANDO <[email protected]> --------- Signed-off-by: Tomohito ANDO <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]>
* feat: add point filters to remove noise due to reflection Signed-off-by: Tomohito ANDO <[email protected]> * fix Signed-off-by: Tomohito ANDO <[email protected]> * filter points under ground Signed-off-by: Tomohito ANDO <[email protected]> --------- Signed-off-by: Tomohito ANDO <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
…g arguments (#334) * feat: add launcher for radar to pass some missing arguments Signed-off-by: Tomohito Ando <[email protected]> * remove unuesed transform node Signed-off-by: Tomohito Ando <[email protected]> * remove unused parameter Signed-off-by: Tomohito Ando <[email protected]> * Revert "remove unuesed transform node" This reverts commit 87b5351. * remove unnecessary comments Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
…ction (#335) * folder for point_filters config yaml * set front_lower multiFOV * set rear_lower multiFOV * set front_upper multiFOV * fix front_upper FOV * fix rear_upper FOV * fix left_lower FOV * edit left_lower FOV * fix right_lower FOV * chore right_lower filter param to avoid rviz error Signed-off-by: kotaro-hihara <[email protected]> * fix left_upper FOV Signed-off-by: kotaro-hihara <[email protected]> * fix right_upper FOV * update left_upper FOV * update right_lower FOV * update rear_upper FOV * change defalut point_filters path * update FOV * update rear_upper FOV * update config of OT128(**_upper) to use one third --------- Signed-off-by: kotaro-hihara <[email protected]>
* enbale topic_state_monitor * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…#340) fix lidar diag name
* remove crop box filter * ci(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
enable self_crop_component
) * fix front_upper lidar FOV * fix right_upper lidar FOV * fix right_lower lidar FOV * fix left_lower lidar FOV * fix right_upper lidar FOV * fix front_lower lidar FOV * fix front_upper lidar FOV * fix rear_upper lidar FOV * fix rear_upper point_filters config * fix point_filters config(correct filter startend angle)
…MJ20-002 (#345) fix left_lower point_filters config with MJ20-002 data
fix front_upper cut_angle
…346) * fix right_lower point_filters * fix left_upper point_filters * fix left_lower point_filters
* fix vertical_bins * enable blockage_diag * fix params for blockage_diag
* fix: cut angle for left_upper and front_upper Signed-off-by: badai-nguyen <[email protected]> * chore: adjust cut angle Signed-off-by: badai-nguyen <[email protected]> * fix: make sure cut_angle equal max angle Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
fix default folder name
fix front_upper filter
* disable motion cancel in converter node because sensor has already done it * remove left/right radar for temporary usage Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
fix lidar distance range
fix blockage_angle
* chore: fix pre-commit errors Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.