Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): mot timer cherrypicks #1236

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

technolojin
Copy link

Description

cherry-pick for mot timer bug fix + latency reduction

timer bug fix
PR autowarefoundation#6757
PR autowarefoundation#6775

latency reduction
PR autowarefoundation#6710

Tests performed

https://evaluation.tier4.jp/evaluation/reports/b0d4a760-d580-5cf4-901c-e44654c59fb4?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

technolojin and others added 3 commits April 9, 2024 18:35
…tialized (autowarefoundation#6757)

fix: debugger timers checks if the timer is initialized

Signed-off-by: Taekjin LEE <[email protected]>
* fix: set object timestamp type to follow node time

fix: remove comment
Signed-off-by: Taekjin LEE <[email protected]>

* fix: add initialization checkers

Signed-off-by: Taekjin LEE <[email protected]>

* fix: timestamp initialization

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
…6710)

* feat: implement a new publish timer

Signed-off-by: Taekjin LEE <[email protected]>

* chore: add comments for new variables

Signed-off-by: Taekjin LEE <[email protected]>

* fix: variable name was wrong

Signed-off-by: Taekjin LEE <[email protected]>

fix: reduce lower limit of publish interval

Signed-off-by: Taekjin LEE <[email protected]>

fix: enlarge publish range upper limit

Signed-off-by: Taekjin LEE <[email protected]>

fix: set parameter tested and agreed

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmpwk shmpwk merged commit 4f814c2 into tier4:beta/v0.26.1 Apr 9, 2024
15 checks passed
@technolojin technolojin deleted the tmp/mot-timer-cherrypicks branch April 10, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants