feat(motion_velocity_smoother)!: added force acceleration #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <[email protected]>
Signed-off-by: Go Sakayori <[email protected]>
Signed-off-by: Go Sakayori <[email protected]>
go-sakayori
requested review from
rej55,
mkuri,
satoshi-ota and
TakaHoribe
as code owners
shmpwk
reviewed
Jun 7, 2024
planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
Outdated
Show resolved
Hide resolved
shmpwk
approved these changes
Jun 7, 2024
shmpwk
reviewed
Jun 7, 2024
planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
Outdated
Show resolved
Hide resolved
|
Owen-Liuyuxuan
pushed a commit
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Yuxuan Liu <[email protected]>
go-sakayori
added a commit
that referenced
this pull request
Aug 6, 2024
* add feature for force acceleration Signed-off-by: Go Sakayori <[email protected]> * Add log info when force acceleration is activated/deactivated Signed-off-by: Go Sakayori <[email protected]> * fix enagage velocity/acceleration Signed-off-by: Go Sakayori <[email protected]> * Update planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp * Update planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]>
go-sakayori
added a commit
that referenced
this pull request
Aug 7, 2024
* add feature for force acceleration Signed-off-by: Go Sakayori <[email protected]> * Add log info when force acceleration is activated/deactivated Signed-off-by: Go Sakayori <[email protected]> * fix enagage velocity/acceleration Signed-off-by: Go Sakayori <[email protected]> * Update planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp * Update planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp --------- Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: Go Sakayori <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add FOA cooperated force acceleration function.
Tests performed
PSim + Experimental vehicle
Effects on system behavior
Accelerates depending on safety operator operation
Interface changes
Added service in motion_velocity_smoother to communicate with FOA.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.