fix: update download link for boost v1.74.0 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shin-kyoto <[email protected]>
Shin-kyoto
requested review from
manato,
softyanija,
TetsuKawa and
Owen-Liuyuxuan
Signed-off-by: Shin-kyoto <[email protected]>
manato
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
@Shin-kyoto
Thank you for the prompt handling of the Boost downloading issue. LGTM.
|
@softyanija |
|
@Shin-kyoto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As you see in boostorg/boost#997, https://boostorg.jfrog.io is out of service. So I updated the link.
Tests performed
I did NOT check this PR by running ansible.
@softyanija , @TetsuKawa , @Owen-Liuyuxuan, can you check this PR by running ansible?
Effects on system behavior
This PR may affect the environment, especially related to boost.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.