chore(expected): make move-constructible

Signed-off-by: Max SCHMELLER <[email protected]>
tier4 · Nov 26, 2024 · 73228ef · 73228ef
1 parent ee790f0
commit 73228ef
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/nebula_common/include/nebula_common/util/expected.hpp b/nebula_common/include/nebula_common/util/expected.hpp
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <exception>
+#include <stdexcept>
 #include <string>
 #include <variant>
 
@@ -97,9 +98,10 @@ struct expected
     return default_;
   }
 
-  expected(const T & value) { value_ = value; }  // NOLINT(runtime/explicit)
-
-  expected(const E & error) { value_ = error; }  // NOLINT(runtime/explicit)
+  expected(const T & value) : value_(value) {}  // NOLINT(runtime/explicit)
+  expected(T && value) : value_(value) {}  // NOLINT(runtime/explicit)
+  expected(const E & error) : value_(error) {}  // NOLINT(runtime/explicit)
+  expected(E && error) : value_(error) {}  // NOLINT(runtime/explicit)
 
 private:
   std::variant<T, E> value_;