Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sync-files): utilize the sync-file-templates repository #248

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 21, 2024

PR Type

  • CI Improvement

Related Links

Parent Issue:

Description

Sync files action helps automating managing repositories by copying files and optionally modifying them along the way.

I've updated them for all of the AWF repositories.

For this repository, you already are using a small subset of these files, here are the changes I've made:

  • Removed pre-commit workflow (This was intended for private repos, you are already using the Github App version ✅. This won't affect anything.)
  • Added tracking of .pre-commit-config.yaml which is shared by all autoware repositories.
  • Removed all build-and-test* from being tracked, I see you are specializing them. It will only complicate things if we keep it here.

Review Procedure

Someone please run sync-files action against this branch. Since this branch is on my fork, you may push the branch to the upstream too.

Or just merge it and run sync-files afterwards. It has been long overdue anyways.

@mitsudome-r @drwnz @mojomex @HansRobo

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: M. Fatih Cırıt <[email protected]>
@mojomex mojomex self-requested a review December 22, 2024 04:17
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@mojomex mojomex merged commit 4669309 into tier4:main Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants