Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ars548): hack to produce correct-looking objects for corner ars548 radars #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Dec 26, 2024

Continental's ARS548 is designed to be on the front/rear of the vehicle.
Rear corner radars have their performance reduced but the data seems ok (confirmed only visually).
However, front corner radars seem to ignore the yaw's configuration. This PR adds a temporal hack to correct the object positions, but will not correct vel/accel values.

PR Type

  • Improvement

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

This essentially assumes that continental ignores the configuration's yaw for FRONT corner radars.
Kinematics will be wrong no matter what...

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 self-assigned this Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 25.62%. Comparing base (77b4c6c) to head (de1ba74).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ontinental/decoders/continental_ars548_decoder.cpp 0.00% 7 Missing and 1 partial ⚠️
...continental/continental_ars548_decoder_wrapper.cpp 0.00% 4 Missing ⚠️
...nental/continental_ars548_hw_interface_wrapper.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   26.11%   25.62%   -0.49%     
==========================================
  Files         100      104       +4     
  Lines        9214     9382     +168     
  Branches     2214     2222       +8     
==========================================
- Hits         2406     2404       -2     
- Misses       6419     6589     +170     
  Partials      389      389              
Flag Coverage Δ
differential 25.62% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex
Copy link
Collaborator

mojomex commented Dec 26, 2024

Thanks for the PR!

Are the yaw angles beyond which this problem occurs known/documented or imperically found?
It would be good, since this is a hack, to

  • print a warning to log when a hacky mounting angle is configured, or
  • (preferably) publish a warning to diagnostics "velocity/accel may be incorrect due to unsupported mounting angle"

Nebula should have some way to make absolutely clear to the user that this is not to be used in safety critical situations.

knzo25 added 3 commits January 8, 2025 09:41
…s (it should only be for evaluation purposes)

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants