Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(AutoDiscoverProvider): implements conflicts discovery #2201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alcidesmig
Copy link

Description

I recently went through a scenario where using an RKE2 cluster it was necessary to create the GKEBackendConfig to maintain compatibility during the migration of some services. Because of this, the networking.gke.io/v1 group was created in the cluster and this caused the tigera/operator to erroneously infer the kubernetesProvider field and lead us to a failure scenario.
Considering this scenario and other similar ones, this MR implements the detection of conflicts during the inference of the Kubernetes Provider, generating an error if more than one provider is detected.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2022

CLA assistant check
All committers have signed the CLA.

@mgleung mgleung modified the milestones: v1.29.0, v1.30.0 Jan 13, 2023
@danudey danudey modified the milestones: v1.30.0, v1.30.1 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants