-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BPF] use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH #3235
Draft
tomastigera
wants to merge
1
commit into
tigera:master
Choose a base branch
from
tomastigera:tomas-bpf-mount
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomastigera
changed the title
use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH
[BPF] use FelixConfiguration.CgroupV2Path to set CALICO_CGROUP_PATH
Mar 8, 2024
Read the CgroupV2Path value from FelixConfiguration and set it as env var for the mount-bpffs node's init container.
tomastigera
force-pushed
the
tomas-bpf-mount
branch
from
March 8, 2024 23:43
9a990c5
to
9b038ac
Compare
5 tasks
Hi all, Thanks for looking into this issue! Do you know if this is still scheduled for release 1.34.0 of the operator? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the CgroupV2Path value from FelixConfiguration and set it as env var for the mount-bpffs node's init container.
fixes projectcalico/calico#7892
Description
For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.