Onboarding Sail (docker)

[gcavanunez]

Highlights

• Onboards sails deps and out of the box docker-compose.yml
• Tweaks the vite config to play nice in none valet environments
• Updates readme and gitignore

Doubts

• Any particular reason https was strict? given sails lets the hostname up in the air, if we want to approach it from our end we could explore adding caddy to the mix
• Given sail out of the box has strong opinions around the .env database config, wasn't 100% if it was worth highlighting on the .env.example or in the actual readme under the sail instructions

References

• Enhancement request: Docker config for local development #91
• Enhancement: Adding Docker configuration for easy setup #92

[driftingly]

Looks good; only one small unrelated suggestion.
Thanks @gcavanunez!

[mattstauffer]

I'm not super familiar with the ideal way to set up the Sail Docker compose file. Should this be ozzie.test? Or is laravel.test the correct config?

[gcavanunez]

Good catch, I think the name is somewhat irrelant though I believe it's what's docker takes in as the name, thus definitely using the ozzie.test would be the way to go

[tonysm]

Uhm, the Laravel service name is kinda hardcoded in the Sail bash script (see here) (it's the main service when we run things like sail artisan ...). Can we also add a APP_SERVICE="ozzie.test" to the .env.example file? This will get carried to the .env when someone is seting up the project.

[tonysm]

Looks good. Left some comments, which should be addressed, but should good to merge IMO after those are handled.