Restart launcher after bgw_scheduler_restart #7594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the scheduler is not restarted, it can affect other tests, so restarting it at the end of the test.
mkindahl
force-pushed
the
flake-bgw-restart
branch
from
1c15c15 to
75ef8ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7594 +/- ##
==========================================
+ Coverage 80.06% 82.30% +2.24%
==========================================
Files 190 238 +48
Lines 37181 44139 +6958
Branches 9450 11101 +1651
==========================================
+ Hits 29770 36330 +6560
- Misses 2997 3425 +428
+ Partials 4414 4384 -30 ☔ View full report in Codecov by Sentry. |
erimatnor
reviewed
Jan 16, 2025
|
|
||
| -- We need to restart the launcher as well to read the reset | ||
| -- configuration or it will affect other tests. | ||
| CALL ts_terminate_launcher(); |
There was a problem hiding this comment.
It says it will restart the launcher, but then "terminate" is called? Is this correct?
There was a problem hiding this comment.
Yes, the launcher restarts automatically after being terminated. It is also verified later in the test, just to make sure that the launcher is actually running when it should.
There was a problem hiding this comment.
Ok, I would recommand clarifying this in the comment for future understanding.
erimatnor
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the scheduler is not restarted, it can affect other tests, so restarting it at the end of the test. Also moving some validation queries to later in the test to make sure that all background workers have restarted properly and read the configuration.
Disable-check: force-changelog-file