Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align AS6212 sample to upstream #93

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jvhutch
Copy link
Contributor

@jvhutch jvhutch commented Jan 30, 2023

  1. Modified callback implementation to align with upstream.
  2. Transitioned high-/low-temperature thresholds macros from main.c module to Kconfig file.
  3. Removed assertion check (CONFIG_ASSERT=y) from prj.conf file.

Signed-off-by: John Hutcherson [email protected]

@jvhutch jvhutch requested a review from kking-1601 January 30, 2023 00:29
@jvhutch jvhutch force-pushed the as6212-sample-upstream-alignment branch from e6848f9 to 622abcb Compare January 30, 2023 19:26
Signed-off-by: John Hutcherson <[email protected]>
@jvhutch jvhutch force-pushed the as6212-sample-upstream-alignment branch from 622abcb to 869a878 Compare January 30, 2023 19:32
@@ -1,5 +1,4 @@
#
# Copyright (c) 2021 Jimmy Johnson <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not remove this copyright notice

@johnlange2
Copy link
Contributor

Please squash your commits

@jvhutch jvhutch marked this pull request as draft February 10, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants