nplusone 적용 및 코드 리팩토링

article/views/article_list_create_api_view.py

@@ -16,7 +16,7 @@
 
 class ArticleListCreateAPIView(BaseView, ListCreateAPIView):
     serializer_class = ArticleSerializer
-    queryset = Article.objects.all().prefetch_related("bookmarks", "feedbacks")
+    queryset = Article.objects.all().prefetch_related("user")
     permission_classes = [IsAuthenticatedOrReadOnly]
     filter_backends = [filters.SearchFilter, filters.OrderingFilter, TagFilter]
     search_fields = ["title", "content"]
@@ -43,6 +43,9 @@ def get(self, request, *args, **kwargs):
         user_id = request.GET.get("user_id")
 
         if tab is not None:
+            if self.is_anonymous_user:
+                return Response(status=204)
+
             if tab == "follow":
                 following_user_ids = Follow.objects.filter(
                     follower=self.current_user
@@ -59,8 +62,10 @@ def get(self, request, *args, **kwargs):
                 studied_article_ids = Study.objects.filter(
                     user=self.current_user
                 ).values_list("article__id", flat=True)
-
-                queryset = queryset.filter(id__in=studied_article_ids).order_by('studies')
+
+                queryset = queryset.filter(id__in=studied_article_ids).order_by(
+                    "studies"
+                )
 
         if user_id is not None:
             queryset = queryset.filter(user__id=user_id)

article/views/article_retrieve_update_destroy_api_view.py

@@ -11,7 +11,7 @@
 
 class ArticleRetrieveUpdateDestroyAPIView(BaseView, RetrieveUpdateDestroyAPIView):
     serializer_class = ArticleSerializer
-    queryset = Article.objects.all().prefetch_related("bookmarks", "feedbacks")
+    queryset = Article.objects.all()
     permission_classes = [IsArticleEditableOrDestroyable]
 
     def get(self, request, *args, **kwargs):

article/views/article_sub_retrieve_api_view.py

@@ -9,7 +9,7 @@
 
 class ArticleSubRetrieveAPIView(BaseView, RetrieveAPIView):
     serializer_class = ArticleSubSerializer
-    queryset = Article.objects.all().prefetch_related("bookmarks", "feedbacks")
+    queryset = Article.objects.all()
     permission_classes = [AllowAny]
 
     def get(self, request, *args, **kwargs):

config/settings.py

@@ -15,6 +15,7 @@
 import os
 from pathlib import Path
 from datetime import timedelta
+import logging
 
 BASE_DIR = Path(__file__).resolve().parent.parent
 SITE_ID = 1
@@ -63,6 +64,8 @@
     # django-extensions
     "django_extensions",
     "django_celery_beat",
+    # nplusone
+    "nplusone.ext.django",
 ]
 
 DJANGO_APPS = [
@@ -85,6 +88,7 @@
     "django.contrib.auth.middleware.AuthenticationMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
+    "nplusone.ext.django.NPlusOneMiddleware",
 ]
 
 ROOT_URLCONF = "config.urls"
@@ -214,6 +218,37 @@
     "USE_SESSION_AUTH": False,
 }
 
+NPLUSONE_LOGGER = logging.getLogger("nplusone")
+NPLUSONE_LOG_LEVEL = logging.DEBUG
+NPLUSONE_RAISE = False
+NPLUSONE_LOG = False
+
+LOGGING = {
+    "version": 1,
+    "handlers": {
+        "console": {
+            "class": "logging.StreamHandler",
+        },
+    },
+    "loggers": {
+        "nplusone": {
+            "handlers": ["console"],
+            "level": "DEBUG",
+        },
+    },
+}
+
+NPLUSONE_WHITELIST = [
+    {"model": "admin.LogEntry", "label": "unused_eager_load"},
+    {"model": "article.Article", "label": "todo"},
+    {"model": "article.Bookmark", "label": "todo"},
+    {"model": "article.Feedback", "label": "todo"},
+    {"model": "article.UploadImage", "label": "todo"},
+    {"model": "comment.Comment", "label": "todo"},
+    {"model": "study.Study", "label": "todo"},
+    {"model": "user.User", "label": "todo"},
+]
+
 CORS_ORIGIN_ALLOW_ALL = True
 
 CORS_ALLOW_CREDENTIALS = True

config/wsgi.py

@@ -10,7 +10,8 @@
 import os
 
 from django.core.wsgi import get_wsgi_application
+from nplusone.ext.wsgi import NPlusOneMiddleware
 
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "config.settings")
 
-application = get_wsgi_application()
+application = NPlusOneMiddleware(get_wsgi_application())

requirements.txt

@@ -5,6 +5,7 @@ astroid==2.9.3
 backports.zoneinfo==0.2.1
 billiard==3.6.4.0
 black==21.12b0
+blinker==1.4
 celery==5.2.3
 certifi==2021.10.8
 cffi==1.15.0
@@ -52,6 +53,7 @@ lizard==1.17.9
 MarkupSafe==2.0.1
 mccabe==0.6.1
 mypy-extensions==0.4.3
+nplusone==1.0.0
 oauthlib==3.1.1
 packaging==21.3
 pathspec==0.9.0

tag/views/tag_list_api_view.py

@@ -1,12 +1,15 @@
-from rest_framework.generics import ListAPIView
 from rest_framework import filters
+from rest_framework.generics import ListAPIView
+from rest_framework.permissions import IsAuthenticatedOrReadOnly
+
 from config.views import BaseView
 from taggit.models import Tag
 from tag.serializers import TagSerializer
 
 
 class TagListAPIView(BaseView, ListAPIView):
     serializer_class = TagSerializer
+    permission_classes = [IsAuthenticatedOrReadOnly]
     queryset = Tag.objects.all()
     filter_backends = [filters.SearchFilter]
     search_fields = ["^name"]