Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oracle DB Extractor #66

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

keenborder786
Copy link

  • Please merge this, I really this. I have added support for Oracle DB in dbcat to get the metadata.

@keenborder786
Copy link
Author

Please merge this.

@SyedBaqarAbbas
Copy link

I need this feature too, you are a lifesaver!

@hussnainahmed
Copy link

+1

@ahmedrayn
Copy link

I need this feature as well.

@vrajat
Copy link
Member

vrajat commented Sep 7, 2023

Thanks for the contribution @keenborder786 . The code looks good to me. Can you add a couple of tests?

These should be easy to add. I'll accept and merge it once the tests run successfully. Also can you confirm that you've tested the changes on an oracle db? I dont have one to test with.

@keenborder786
Copy link
Author

@vrajat okay.

@vrajat vrajat self-requested a review September 21, 2023 09:32
@vrajat
Copy link
Member

vrajat commented Oct 12, 2023

I've merged #67 as it used servicename and _create_sqlalchemy_extractor in the diff. I see that the NOT IN clause is not the same. Can you check and see if that requires a change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants