feat: new screenshots view #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepan662
force-pushed
the
stepangranat/new-screenshots
branch
from
7375360 to
4bbeff6
Compare
JanCizmar
approved these changes
Jan 20, 2025
webapp/src/views/projects/translations/Screenshots/Screenshots.tsx
Outdated
Show resolved
Hide resolved
|
Before we merge it. Wouldn't it makes sense to limit the height of the screenshot so the key doesn't have so large height? In most cases there is just one screenshot and most of the people have enabled just 2 languages, so by this we very probably make it much less keys visible on the single page scroll area. @ZuzanaOdstrcilova
|
|
Yeah, sounds good. There is a limit of 350px. But I'd make it lower, like 200px or maybe 150 |
|
Thanks! |
|
We can make it smaller. If we want more keys on one page, I would try even 150. |
|
I didn't see it, but I would probably also vote for less then more. I know it's a tradeoff, but the users currently appreciate the clarity of the view, so I don't want to break it by adding a lot of empty areas. |
stepan662
force-pushed
the
stepangranat/new-screenshots
branch
from
2ba4119 to
80bc37d
Compare
JanCizmar
approved these changes
Jan 22, 2025
TolgeeMachine
added a commit
that referenced
this pull request
Jan 22, 2025
# [3.96.0](v3.95.0...v3.96.0) (2025-01-22) ### Features * new screenshots view ([#2846](#2846)) ([661ee7e](661ee7e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.