Merge pull request #35 from tomas-gajarsky/hotfix/test_detector_downl…

…oader Hotfix/test detector downloader
tomas-gajarsky · Feb 2, 2023 · 890cb7e · 890cb7e
2 parents b8fc7a2 + 82c7bb1
commit 890cb7e
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 5 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1 +1,2 @@
 notebooks/** linguist-vendored
+*.mako linguist-vendored
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # Change Log
 
+
+## 0.2.3
+
+Released on February 2, 2023.
+
+### Fixed
+* error in detector test
+
+### Removed
+* deletion of detector model in tests
+
+
 ## 0.2.2
 
 Released on January 28, 2023.

diff --git a/conf/analyzer/detector/retinaface.yaml b/conf/analyzer/detector/retinaface.yaml
@@ -3,7 +3,7 @@ _target_: facetorch.analyzer.detector.FaceDetector
 
 downloader:
   _target_: facetorch.downloader.DownloaderGDrive
-  file_id: 154x2VjmTQVqmowB0yZw4Uck7uQs2vVBs  # str
+  file_id: 1eMuOdGkiNCOUTiEbKKoPCHGCuDgiKeNC  # str
   path_local: /opt/facetorch/models/torchscript/detector/1/model.pt # str
 
 device:

diff --git a/tests/test_detector.py b/tests/test_detector.py
@@ -9,8 +9,6 @@
 @pytest.mark.detector
 @pytest.mark.downloader
 def test_downloader_run(analyzer):
-    if os.path.exists(analyzer.detector.downloader.path_local):
-        os.remove(analyzer.detector.downloader.path_local)
     analyzer.detector.downloader.run()
     assert os.path.exists(analyzer.detector.downloader.path_local)
 

diff --git a/tests/test_predictors.py b/tests/test_predictors.py
@@ -12,7 +12,8 @@ def test_downloaders_run(analyzer):
     for predictor in analyzer.predictors.values():
         # if os.path.exists(predictor.downloader.path_local):
         # os.remove(predictor.downloader.path_local)
-        predictor.downloader.run()
+        if not os.path.exists(predictor.downloader.path_local):
+            predictor.downloader.run()
         assert os.path.exists(predictor.downloader.path_local)
 
 

diff --git a/version b/version
@@ -1 +1 @@
-0.2.2
+0.2.3
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		notebooks/** linguist-vendored
		*.mako linguist-vendored