Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable introspection option to gql #29

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

egs33
Copy link
Member

@egs33 egs33 commented Dec 5, 2024

Add option to control whether schema introspection is enabled.

Graph QL introspection is convinient, but it's could be a security issue in production.

The default value is nil, which means it is disabled.

https://github.com/walmartlabs/lacinia/blob/99d71e17344577bb71f48b03aa88d22853be6277/src/com/walmartlabs/lacinia/schema.clj#L2015-L2017

@egs33 egs33 requested a review from liquidz December 5, 2024 02:47
@egs33 egs33 marked this pull request as ready for review December 5, 2024 02:47
Copy link
Member

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egs33 I've confirmed that it is disabled by default and can be enabled by option.
LGTM!

@egs33
Copy link
Member Author

egs33 commented Dec 5, 2024

🙏

@egs33 egs33 merged commit bf5840a into main Dec 5, 2024
1 check passed
@egs33 egs33 deleted the add-enable-introspection-option-to-gql branch December 5, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants