fix: hang bug due to never ending polling loop (#11)

traceloop · Nov 8, 2023 · efcda85 · efcda85
1 parent b8f6c5c
commit efcda85
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/instrumentation-openai/package.json b/packages/instrumentation-openai/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@traceloop/instrumentation-openai",
-  "version": "0.0.18",
+  "version": "0.0.19",
   "description": "OpenTelemetry ai-specific semantic conventions",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

diff --git a/packages/instrumentation-openai/src/instrumentation.ts b/packages/instrumentation-openai/src/instrumentation.ts
@@ -187,7 +187,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<any> {
           attributes[`${SpanAttributes.LLM_PROMPTS}.${index}.role`] =
             message.role;
           attributes[`${SpanAttributes.LLM_PROMPTS}.${index}.content`] =
-            message.content || "";
+            (message.content as string) || "";
         });
       } else {
         if (typeof params.prompt === "string") {

diff --git a/packages/sample-app/src/sample_with.ts b/packages/sample-app/src/sample_with.ts
@@ -9,7 +9,7 @@ traceloop.initialize({
 const openai = new OpenAI();
 
 async function chat() {
-  return traceloop.withWorkflow("sample_chat", async () => {
+  return await traceloop.withWorkflow("sample_chat", async () => {
     const chatCompletion = await openai.chat.completions.create({
       messages: [
         { role: "user", content: "Tell me a joke about OpenTelemetry" },
@@ -22,7 +22,7 @@ async function chat() {
 }
 
 async function completion() {
-  return traceloop.withWorkflow("sample_completion", async () => {
+  return await traceloop.withWorkflow("sample_completion", async () => {
     const completion = await openai.completions.create({
       prompt: "Tell me a joke about TypeScript",
       model: "gpt-3.5-turbo-instruct",

diff --git a/packages/traceloop-sdk/package.json b/packages/traceloop-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@traceloop/node-server-sdk",
-  "version": "0.0.18",
+  "version": "0.0.19",
   "description": "Traceloop Software Development Kit (SDK) for Node.js",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",
@@ -34,7 +34,7 @@
   "dependencies": {
     "@opentelemetry/exporter-trace-otlp-proto": "^0.44.0",
     "@opentelemetry/sdk-node": "^0.44.0",
-    "@traceloop/instrumentation-openai": "^0.0.18",
+    "@traceloop/instrumentation-openai": "^0.0.19",
     "@types/nunjucks": "^3.2.5",
     "fetch-retry": "^5.0.6",
     "nunjucks": "^3.2.4",

diff --git a/packages/traceloop-sdk/src/lib/configuration/index.ts b/packages/traceloop-sdk/src/lib/configuration/index.ts
@@ -28,7 +28,7 @@ export const initialize = (options: InitializeOptions) => {
     options.appName = process.env.npm_package_name;
   }
 
-  if (!options.traceloopSyncEnabled) {
+  if (options.traceloopSyncEnabled === undefined) {
     if (process.env.TRACELOOP_SYNC_ENABLED !== undefined) {
       options.traceloopSyncEnabled = ["1", "true"].includes(
         process.env.TRACELOOP_SYNC_ENABLED.toLowerCase(),

diff --git a/packages/traceloop-sdk/src/lib/prompts/registry.ts b/packages/traceloop-sdk/src/lib/prompts/registry.ts
@@ -34,6 +34,7 @@ const populateRegistry = (prompts: any) => {
 export const initializeRegistry = (options: InitializeOptions) => {
   const {
     baseUrl,
+    suppressLogs,
     traceloopSyncEnabled,
     traceloopSyncPollingInterval,
     traceloopSyncDevPollingInterval,
@@ -55,8 +56,12 @@ export const initializeRegistry = (options: InitializeOptions) => {
         try {
           const { prompts } = await fetchPrompts(options);
           populateRegistry(prompts);
-        } catch (err) {}
-      }, pollingInterval! * 1000);
+        } catch (err) {
+          if (!suppressLogs) {
+            console.error("Failed to fetch prompt data", err);
+          }
+        }
+      }, pollingInterval! * 1000).unref();
 
       return true;
     })