Use Node.js test runner #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
# Conflicts: # .github/workflows/ci-monolib.yml # package.json # yarn.lock
|
the passes make me think you figured the mocking part out is that correct? If so i'm open to merging the node test runner once the conflict has been resolved 👌 |
|
I did not figure it out yet, the tests for |
|
@aduh95 do you have time next week to pair on this? Tuesday would be most convenient on my side, any time is good, does that work for you? |
|
Sure let's do tuesday 10am? |
|
Ok, sounds good 👍 |
aduh95
reviewed
Nov 28, 2023
aduh95
reviewed
Nov 28, 2023
Co-authored-by: Antoine du Hamel <[email protected]>
# Conflicts: # .eslintrc.js # package.json # packages/prd/src/prd.test.ts # packages/prettier-bytes/src/prettierBytes.ts # packages/trigger-pager/src/triggerPager.test.ts # tsconfig.json # yarn.lock
# Conflicts: # .github/workflows/ci-monolib.yml # package.json # packages/enrich-tweet/src/enrichTweet.test.ts # tsconfig.json # yarn.lock
aduh95
reviewed
Nov 28, 2023
aduh95
reviewed
Nov 28, 2023
aduh95
approved these changes
Nov 29, 2023
|
Cool, thanks for cleaning up this repo both!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took an hour and had some fun converting the test suite here to
node:test. The only one I'm having trouble with (mocking the pagerduty import in particular) istriggerPager.test.ts. @aduh95 think you could take a look at that?