-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eliminate the lodash.get
dependency
#964
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Bundle ReportChanges will increase total bundle size by 695 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #964 +/- ##
==========================================
- Coverage 78.46% 78.44% -0.03%
==========================================
Files 403 403
Lines 6692 6694 +2
==========================================
Hits 5251 5251
- Misses 1441 1443 +2 ☔ View full report in Codecov by Sentry. |
Tonic UI DemoOn 2025-01-18 08:41:44 +0000, PR #964 (a000ea7) was successfully deployed. You can view it at the following link: |
PR Type
Enhancement, Dependencies
Description
Removed the
lodash.get
dependency across the codebase.Replaced
lodash.get
usage with optional chaining and nullish coalescing.Updated
package.json
to removelodash.get
from dependencies.Changes walkthrough 📝
base-css.js
Replace `lodash.get` with optional chaining in base CSS
packages/react/src/css-baseline/base-css.js
lodash.get
and replaced with optional chaining.styles.js
Replace `lodash.get` with optional chaining in drawer styles
packages/react/src/drawer/styles.js
lodash.get
and replaced with optional chaining.styles.js
Replace `lodash.get` with optional chaining in modal styles
packages/react/src/modal/styles.js
lodash.get
and replaced with optional chaining.package.json
Remove `lodash.get` from package dependencies
packages/react/package.json
lodash.get
from dependencies.