Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cardano): allow address_index in staking paths #3242

Merged
merged 3 commits into from
Oct 19, 2023
Merged

feat(cardano): allow address_index in staking paths #3242

merged 3 commits into from
Oct 19, 2023

Conversation

davidmisiak
Copy link
Contributor

Changes:

  • Cardano multidelegation - allowing address index to be non-zero in staking paths (in line with CIP-11).
  • A little note that Cardano token decimals are unknown displayed when sending/minting tokens.

@davidmisiak davidmisiak requested a review from matejcik as a code owner August 30, 2023 15:12
@davidmisiak
Copy link
Contributor Author

Hi @matejcik, just wanted to ask whether you have an idea when could this PR be processed.

@davidmisiak
Copy link
Contributor Author

@matejcik any updates please?

@matejcik
Copy link
Contributor

code LGTM.
please also regenerate fixtures for model R (build the emulator with TREZOR_MODEL=R)

@davidmisiak davidmisiak force-pushed the cardano-multidelegation branch from f0190de to 3fd9d41 Compare October 11, 2023 16:40
@davidmisiak
Copy link
Contributor Author

All fixtures should be up to date; rebased on master.

@davidmisiak
Copy link
Contributor Author

@matejcik is this ready to be merged?

@matejcik
Copy link
Contributor

code-wise yes, but github has a problem (seems related to the master -> main rename)
please rebase manually on top of current main branch and force-push

@davidmisiak davidmisiak force-pushed the cardano-multidelegation branch from 3fd9d41 to 8b42687 Compare October 18, 2023 13:53
@davidmisiak
Copy link
Contributor Author

Rebased. There was also a conflict in fixtures.json, but it should be fixed now.

@matejcik
Copy link
Contributor

waiting for CI

@matejcik matejcik merged commit a945de8 into trezor:main Oct 19, 2023
8 checks passed
@davidmisiak davidmisiak mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmisiak @matejcik