Update Python and Pillow #3336
Merged
Update Python and Pillow #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see anything obvious. Perhaps we need to bump nixpkgs for 3.12 to work, there might be some bugfixes in more recent package. |
|
3.11 seems to fail on aio-libs/aiohttp#6600 |
|
the too-old stellar sdk is holding us back, I'll see if I can fix it easily |
matejcik
force-pushed
the
matejcik/update-pillow
branch
from
e4e2396 to
e1ff3ca
Compare
matejcik
requested review from
andrewkozlik,
prusnak and
onvej-sl
as code owners
|
rebased on top of |
fixes a problem with outdated python 3.11 dependencies
matejcik
force-pushed
the
matejcik/update-pillow
branch
from
35258f3 to
ec5fc55
Compare
mmilata
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves dependabot errors about vulnerable libwebp. We should not be affected by the vulnerability, but better safe than sorry.
It also adds Python 3.11 to the tox matrix for trezorlib.
I tried adding Python 3.12 but it fails because something something distutils -- they were removed from Python in 3.12, but tooling still depends on them. My guess is that we'd need to upgrade pip / setuptools / poetry, but I'm not sure which of them and how exactly. @mmilata if you could take a brief look and see if you can fix it easily, that would be nice; if not, let's live without Py3.12 for now.