Request signature optional #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekrjpolak
force-pushed
the
cj-unsigned
branch
4 times, most recently
from
1996837 to
f41ab95
Compare
marekrjpolak
force-pushed
the
cj-unsigned
branch
2 times, most recently
from
a387997 to
9d521db
Compare
matejcik
reviewed
Jun 7, 2024
[no changelog]
[no changelog]
matejcik
reviewed
Jun 7, 2024
[no changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips
mask_public_keyandsignaturechecks when they're received as empty from client.Legacy fw changes were difficult to test because of this issue, but the same changes applied to 1.12.1 worked fine.
More rationale in Notion: https://www.notion.so/satoshilabs/Request-signature-checks-removal-bc5f3174ca9543e6ae31b6bc08087e76