Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated kingfisher workflow #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SilasK
Copy link

@SilasK SilasK commented Feb 24, 2023

I added some new rules from atlas init-sra e.g. the filtering part.

I aggregate with the 'sample_accession' variable which what the only one in my dataset. but I like your approach to search for SAMN column.

I added the resource to limit the number of connections and show how to do it in the Readme.

The workflow does not know how to handle mixed reads e.g. paired and unpaired reads.

I test the workflow now on only paired-end samples.

Todo:

  • repalce the conda env
  • test on another dataset.

@trickovicmatija have a look at the pathlib library. I prefer it over os.path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant