Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some new rules from atlas init-sra e.g. the filtering part.
I aggregate with the 'sample_accession' variable which what the only one in my dataset. but I like your approach to search for SAMN column.
I added the resource to limit the number of connections and show how to do it in the Readme.
The workflow does not know how to handle mixed reads e.g. paired and unpaired reads.
I test the workflow now on only paired-end samples.
Todo:
@trickovicmatija have a look at the pathlib library. I prefer it over os.path.