Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow options in command, add travis integration, and update readme #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

almasaeed2010
Copy link

Hello,

This pull request adds travis CI integration to tripal_install. To make this possible we had to refactor the code to accept a non-interactive mode where all the options are passed through the cli.

However, since we don't own the repo we couldn't validate the travis yaml file. But that should automatically happens once you enable travis on your end before merging this pull request. From there, we can update the code until it passes then merge.

Please let me know if you have any questions.

Thanks!

@almasaeed2010
Copy link
Author

Running the tests yields that this works with php 7.0, 7.1 but not 7.2
screen shot 2018-03-27 at 1 10 36 pm

@shawnawsu
Copy link
Member

I am so sorry I didn't see this till now, I was apparently not watching this repo.

This pull request troubles me. I understand the desire to test it with travis but it adds a lot of additional code that doesn't speak to performing the required tasks and seems overcomplicated, and far from the ideal of maintaining simplicity of code.

@spficklin, thoughts?

@spficklin
Copy link
Member

@shawnawsu I think we should merge this in as we do need some travis CI integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants