Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoding libonnxruntime.so.1 library name reference value #264

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Aug 15, 2024

This is a quick fix to tritonserver container backend. which fix non-found libonnxruntime.so.1

$ docker run --rm -it  tritonserver:24.08-py3-base bash -c "ldd backends/onnxruntime/libtriton_onnxruntime.so" | grep found
        libtritonserver.so => not found
        libonnxruntime.so.1 => not found

Related issue: microsoft/onnxruntime#21763

@mc-nv mc-nv requested a review from pvijayakrish August 15, 2024 15:18
@mc-nv mc-nv marked this pull request as ready for review August 15, 2024 19:05
@pvijayakrish
Copy link
Contributor

Do we have a RCA? Is this a temporary fix to unblock QA for 24.08 testing?

@mc-nv
Copy link
Contributor Author

mc-nv commented Aug 15, 2024

Do we have a RCA? Is this a temporary fix to unblock QA for 24.08 testing?

We have to accept change and rebuild the image to provide image to QA

@pvijayakrish
Copy link
Contributor

Approving the temporary fix to unblock QA for 24.08 testing. Please create a follow up ticket, if required, to investigate and adopt a permanent solution.

pvijayakrish
pvijayakrish previously approved these changes Aug 15, 2024
@mc-nv mc-nv requested a review from pvijayakrish August 16, 2024 00:07
@mc-nv mc-nv changed the title Hardcoding libonnxruntime.so.1 library name value Hardcoding libonnxruntime.so.1 library name reference value Aug 16, 2024
@mc-nv mc-nv merged commit ab34b48 into r24.08 Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants