Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters support to InferenceRequest #313

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add parameters support to InferenceRequest #313

merged 2 commits into from
Oct 24, 2023

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Oct 19, 2023

Related PR: triton-inference-server/server#6452

Add support for BLS models to specify parameters as a dictionary to be passed to the next model. The key and value pairs on the dictionary require keys to be a string and values can be a string, integer or boolean.

@kthui kthui marked this pull request as ready for review October 19, 2023 22:28
@kthui kthui requested review from oandreeva-nv, krishung5 and Tabrizian and removed request for oandreeva-nv and krishung5 October 19, 2023 22:29
@kthui kthui requested a review from oandreeva-nv October 19, 2023 22:56
src/pb_stub.cc Outdated Show resolved Hide resolved
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except what Kris pointed out, it looks good to me.

@kthui kthui requested review from Tabrizian and krishung5 October 24, 2023 19:14
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helper function!

@kthui kthui merged commit a8e6193 into main Oct 24, 2023
3 checks passed
@kthui kthui deleted the jacky-parameters branch October 24, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants