Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/test: RHEL8 EA3 #7595

Merged
merged 3 commits into from
Sep 11, 2024
Merged

build/test: RHEL8 EA3 #7595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eeb0f9
Add L0_sequence_batcher to RHEL smoke tests
fpetrini15 Aug 28, 2024
78949b4
Avoid block
fpetrini15 Aug 31, 2024
392cf5c
Review comments
fpetrini15 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,12 +1374,15 @@ def dockerfile_prepare_container_linux(argmap, backends, enable_gpu, target_mach

if enable_gpu:
df += install_dcgm_libraries(argmap["DCGM_VERSION"], target_machine)
df += """
# This segment will break the RHEL SBSA build. Need to determine whether
# this is necessary to incorporate.
if target_platform() != "rhel":
df += """
# Extra defensive wiring for CUDA Compat lib
RUN ln -sf ${_CUDA_COMPAT_PATH}/lib.real ${_CUDA_COMPAT_PATH}/lib \\
&& echo ${_CUDA_COMPAT_PATH}/lib > /etc/ld.so.conf.d/00-cuda-compat.conf \\
&& ldconfig \\
&& rm -f ${_CUDA_COMPAT_PATH}/lib
&& echo ${_CUDA_COMPAT_PATH}/lib > /etc/ld.so.conf.d/00-cuda-compat.conf \\
&& ldconfig \\
&& rm -f ${_CUDA_COMPAT_PATH}/lib
"""
else:
df += add_cpu_libs_to_linux_dockerfile(backends, target_machine)
Expand Down
21 changes: 18 additions & 3 deletions qa/L0_sequence_batcher/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright 2018-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2018-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -183,6 +183,16 @@ export USE_SINGLE_BUFFER
# models4 - four instances with batch-size 1
rm -fr *.log models{0,1,2,4} queue_delay_models && mkdir models{0,1,2,4} queue_delay_models

# Search BACKENDS to determine if a backend should be tested
function should_test_backend() {
nv-kmcgill53 marked this conversation as resolved.
Show resolved Hide resolved
local target_backend=$1
nv-kmcgill53 marked this conversation as resolved.
Show resolved Hide resolved
if [[ $(echo "${BACKENDS[@]}" | grep -c "${target_backend}") -ne 0 ]]; then
echo "true"
return
fi
echo "false"
}

# Get the datatype to use based on the backend
function get_datatype () {
local dtype="int32 bool"
Expand Down Expand Up @@ -827,8 +837,13 @@ fi

### Start Preserve Ordering Tests ###

# Test only supported on windows currently due to use of python backend models
if [ ${WINDOWS} -ne 1 ]; then
# FIXME: Test only supported on windows currently due to use of python backend models.
# Now that Windows supports the PYBE, we should check that this tests works once Windows
# CI is stable.

# These subtests use python models. They should not be executed if 'python' is not one
# of the backends under test.
if [[ $(should_test_backend "python") == "true" && !( -v WSL_DISTRO_NAME || -v MSYSTEM )]]; then
# Test preserve ordering true/false and decoupled/non-decoupled
TEST_CASE=SequenceBatcherPreserveOrderingTest
MODEL_PATH=preserve_ordering_models
Expand Down
Loading