Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor of L0_backend_python and the env subtest #7838

Draft
wants to merge 3,470 commits into
base: main
Choose a base branch
from

Conversation

nv-kmcgill53
Copy link
Contributor

What does the PR do?

This PR refactors the L0_backend_python test to be able to incrementally run different parts of the test by using variables rather than having to comment out large sections of code.

Additionally this PR also refactors the env subtest to make use of configurable variables to run certain parts of the test on demand. This allows the L0_backend_python test to potentially be parallelized in the CI. This also turns silent failures into verbose failures, such as the Locale test in the env subtest currently failing even thought the CI says it's passing.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/python_backend#260
triton-inference-server/python_backend#384

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

whoisj and others added 30 commits January 17, 2024 17:26
This validates the change made to ../core wrt how model configuration mtime is handled.
* Run all cases wihh shm probe

* Warmup test and then run multiple iterations

* Log free shared memory on enter/exit of probe

* Add shm probe to all tests

* Add debug_str to shm_util

* Refactor ensemble_io test, modify probe to check for growth rather than inequality

* Improve stability of bls_tensor_lifecycle gpu memory tests

* Add more visibility into failing model/case in python_unittest helper

* [FIXME] Skip probe on certain subtests for now

* [FIXME] Remove shm probe from test_restart on unhealthy stub

* Start clean server run for each bls test case

* Don't exit early on failure so logs can be properly collected

* Restore bls test logic

* Fix shm size compare

* Print region name that leaked

* Remove special handling on unittest

* Remove debug str

* Add enter and exit delay to shm leak probe

---------

Co-authored-by: Ryan McCormick <[email protected]>
* Update trace_summery script

* Remove GRPC_WAITREAD and Overhead
* Add gsutil cp retry helper function

* Add max retry to GCS upload

* Use simple sequential upload
* Handle empty output

* Add test case for 0 dimension output

* Fix up number of tests
* tensorrt-llm benchmarking test
* Update README and versions for 2.42.0 / 24.01 (#6789)

* Update versions

* Update README and versions for 2.42.0 / 24.01

* Fix documentaation genarion (#6801)

* Ser version of sphix to 5.0

* Set verions 5.0.0

* Update README.md and versions post 24.01
…und (#6834)

* Update miniconda version

* Install pytest for different py version

* Install pytest
* Add test for shutdown while loading

* Fix intermittent failure on test_model_config_overwrite
Adding OpenTelemetry Batch Span Processor
---------

Co-authored-by: Theo Clark <[email protected]>
Co-authored-by: Ryan McCormick <[email protected]>
* Support Double-Type Infer/Response Parameters
* Base Python Backend Support for Windows
* Add unit test reports to L0_dlpack_multi_gpu

* Add unit test reports to L0_warmup
* Add response statistics

* Add L0_response_statistics

* Enable http vs grpc statistics comparison

* Add docs for response statistics protocol

* Add more comments for response statistics test

* Remove model name from config

* Improve docs wordings

* [Continue] Improve docs wordings

* [Continue] Add more comments for response statistics test

* [Continue 2] Improve docs wordings

* Fix typo

* Remove mentioning decoupled from docs

* [Continue 3] Improve docs wordings

* [Continue 4] Improve docs wordings

Co-authored-by: Ryan McCormick <[email protected]>

---------

Co-authored-by: Ryan McCormick <[email protected]>
* Switch to Python model for busyop test

* Clean up

* Address comment

* Remove unused import
* Add cancellation into response statistics

* Add test for response statistics cancel

* Remove debugging print

* Use is None comparison

* Fix docs

* Use default args None

* Refactor RegisterModelStatistics()
mc-nv and others added 26 commits November 1, 2024 15:27
…t version map to dictionary (#7500)

Co-authored-by: Olga Andreeva <[email protected]>
Co-authored-by: Kyle McGill <[email protected]>
Co-authored-by: Anant Sharma <[email protected]>
Co-authored-by: Jacky <[email protected]>
Co-authored-by: Kris Hung <[email protected]>
…map for the different subtests of the L0_backend_python test
@nv-kmcgill53 nv-kmcgill53 added PR: ci Changes to our CI configuration files and scripts PR: refactor A code change that neither fixes a bug nor adds a feature labels Nov 27, 2024
@pvijayakrish pvijayakrish force-pushed the kmcgill-refactor-L0_backend_python branch from deb693b to f6b3275 Compare January 15, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ci Changes to our CI configuration files and scripts PR: refactor A code change that neither fixes a bug nor adds a feature
Development

Successfully merging this pull request may close these issues.