-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show semester name and school year when displaying semsester and year. #1163
base: master
Are you sure you want to change the base?
Conversation
@@ -5,6 +5,9 @@ | |||
<tr> | |||
<th colspan="3" class="active"> | |||
{{ year }}. ročník | |||
{% if competition.founded %} | |||
({{ competition.founded|add:year }}/{{ competition.founded|add:year|add:"1" }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asi by bolo vhodnejšie spraviť metódu pre semester že school_year
ktorá vráti string 2017/2018
a volať tú.
@@ -10,6 +10,9 @@ <h1>Výsledky<small> | |||
{{ scoreboard.round.number }}. kola{% else %}po {{ scoreboard.round.number }}. kole | |||
{% endif %} | |||
{{ scoreboard.round.semester.number }}. časti {{ scoreboard.round.semester.year }}. ročníka | |||
{% if competition_founded %} | |||
({{ competition_founded|add:year }}/{{ competition_founded|add:year|add:"1" }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
school year
return '%i. (%s) časť, %i. ročník %s'\ | ||
% (self.number, self.name, self.year, self.competition) | ||
semester_name = '(%s) ' % self.name if len(self.name) > 0 else '' | ||
school_year = '(%d/%d) ' % (self.competition.founded + self.year, self.competition.founded + self.year + 1) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do funkcie, viď nižšie
@@ -6,10 +6,9 @@ | |||
|
|||
{% block page_header %} | |||
<h1> | |||
Zadania | |||
Zadania<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toto by sme mohli mať ujednotené, že či teda ide názov kola vedľa alebo popod.
Podľa mňa keď sa to zmestí v pohode do riadku, tak nech je to vedľa (nech zbytočne neplytváme vertikálnym miestom).
Ak to vyzerá škaredo, možno stačí medzi pridať väčšiu medzeru?
Vyskytuje sa to ešte minimálne v list_active_rounds_tasks, v round_submit a tiež vo výsledkovkách ... a možno aj inde - najlepšie to skúsiť vyregexiť v kóde? preklikať sa stránkou?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pôvodne tam bolo Zadania # kola # časti..., teda názov časti by bolo treba vyskloňovať, tak preto som to oddelil, neoddelené si tak viac pýta skloňovanie :D, ale asi bude v pohode v riadku a nevyskloňované. Alebo mám sa nejako pohrať so skloňovaním?
Preklikával som sa, na tých dvoch miestach, čo si dal, sa volá str() na round a to som prerobil, aby zobrazovalo aj názov časti, aj šk. rok. Ešte to checknem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hej, na niektorých stránkach je to vyskloňované (aj pri výsledkoch) a na ostatných sa dáva priamo {{round}}
, v pohode to tam nechaj nevyskloňované.
A viem, že sa tam volá str. Tie ostatné linky som tam dal hlavne pre ukázanie ako je to spravené inde - možno tam tiež pridať nejako medzeru? miesto small
spraviť class v css?
👉 @dodo42 |
Closes #1162