Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change metadata to snake_case #23

Merged
merged 1 commit into from
Jun 25, 2024
Merged

change metadata to snake_case #23

merged 1 commit into from
Jun 25, 2024

Conversation

stavros-k
Copy link
Contributor

No description provided.

@stavros-k stavros-k requested review from Qubad786 and sonicaj June 25, 2024 12:59
sonicaj
sonicaj approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@sonicaj sonicaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you push a PR to apps please too to see if the testing app we have requires this change ?
Also can you please fix it's values file as well because we are trying to use a value in the compose template which does not exist in it's questions.yaml ? Ty

@stavros-k stavros-k merged commit db7d1b2 into master Jun 25, 2024
2 checks passed
@stavros-k stavros-k deleted the casing branch June 25, 2024 15:33
@stavros-k
Copy link
Contributor Author

Can you push a PR to apps please too to see if the testing app we have requires this change ? Also can you please fix it's values file as well because we are trying to use a value in the compose template which does not exist in it's questions.yaml ? Ty

Ready!
truenas/apps#33

@stavros-k stavros-k mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonicaj sonicaj sonicaj approved these changes

@Qubad786 Qubad786 Awaiting requested review from Qubad786

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stavros-k @sonicaj