Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132705 / 25.04 / Adopts middleware changes to CPU and memory reporting on the dashboard widgets #11317

Merged
merged 21 commits into from
Jan 19, 2025

Conversation

RehanY147
Copy link
Contributor

Changes:

Adopts middleware changes to CPU reporting on the dashboard widgets. Removes temperature related reporting also temperature for cpu widget

Testing:

With a recent build, CPU stats related widgets should work correctly. Also shouldn't show any errors in the console logs

@RehanY147 RehanY147 requested a review from a team as a code owner January 9, 2025 09:48
@RehanY147 RehanY147 requested review from undsoft and removed request for a team January 9, 2025 09:48
@bugclerk bugclerk changed the title Adopts middleware changes to CPU reporting on the dashboard widgets NAS-132705 / 25.04 / Adopts middleware changes to CPU reporting on the dashboard widgets Jan 9, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a number of issues most of them are not because of changes in this PR, but let's still fix them.

  1. I get toSignal error. Can be fixed by adding .pipe(startWith(0)) to refreshInterval$ in WidgetResourcesService.
  2. I've tried simulating load on CPU to test the widget and noticed that load is reported as System on main chart, but bars don't show much. Looks like an issue with MW reporting. I think users would expect to see total load on bars as well.
Снимок экрана 2025-01-09 в 11 10 13 3. Memory overview widget doesn't load. 4. Let's remove CPU Usage Per Core from default set of widgets as currently there is a gap there.

@RehanY147 RehanY147 changed the title NAS-132705 / 25.04 / Adopts middleware changes to CPU reporting on the dashboard widgets NAS-132705 / 25.04 / Adopts middleware changes to CPU and memory reporting on the dashboard widgets Jan 13, 2025
@RehanY147 RehanY147 requested a review from undsoft January 13, 2025 21:03
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the discrepancy between CPU load in various widgets (System vs User), the rest looks good.
Let's ask MW to look into this.

package.json Outdated
@@ -80,6 +80,7 @@
"@lezer/common": "~1.2.1",
"@lezer/generator": "~1.7.1",
"@lezer/lr": "~1.4.2",
"@marijn/find-cluster-break": "~1.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this package is needed. It's not used anywhere and it works for me without it. Sounds like an issue on your end.

@RehanY147 RehanY147 enabled auto-merge (squash) January 18, 2025 01:23
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (0ddcd50) to head (962f268).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...app-resources-card/app-resources-card.component.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11317   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files        1659     1659           
  Lines       59376    59360   -16     
  Branches     6241     6232    -9     
=======================================
- Hits        49184    49173   -11     
+ Misses      10192    10187    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RehanY147 RehanY147 merged commit 62bbc27 into master Jan 19, 2025
11 checks passed
@RehanY147 RehanY147 deleted the NAS-132705-alt branch January 19, 2025 13:19
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants