Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): update to latest vc-go. #646

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore(sdk): update to latest vc-go. #646

merged 1 commit into from
Oct 24, 2023

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Oct 23, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (b77aa73) 89.23% compared to head (de677a6) 89.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   89.23%   89.07%   -0.16%     
==========================================
  Files         102      102              
  Lines        4060     4102      +42     
==========================================
+ Hits         3623     3654      +31     
- Misses        298      306       +8     
- Partials      139      142       +3     
Files Coverage Δ
cmd/wallet-sdk-gomobile/display/resolve.go 85.36% <100.00%> (ø)
cmd/wallet-sdk-gomobile/openid4vp/interaction.go 81.63% <100.00%> (ø)
pkg/common/jwt_signer.go 89.83% <100.00%> (+0.54%) ⬆️
pkg/common/keyresolver.go 100.00% <100.00%> (ø)
pkg/credentialquery/credentialquery.go 100.00% <100.00%> (ø)
pkg/credentialschema/opts.go 94.56% <100.00%> (ø)
pkg/internal/issuermetadata/issuermetadata.go 75.00% <100.00%> (ø)
pkg/openid4ci/interaction.go 88.16% <100.00%> (-0.17%) ⬇️
pkg/openid4ci/issuerinitiatedinteraction.go 91.85% <100.00%> (ø)
pkg/openid4ci/walletinitiatedinteraction.go 78.18% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkubiv vkubiv changed the title chore: update to latest vc-go. chore(sdk): update to latest vc-go. Oct 23, 2023
Signed-off-by: Volodymyr Kubiv <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vkubiv vkubiv merged commit 24981bb into trustbloc:main Oct 24, 2023
15 checks passed
@vkubiv vkubiv deleted the chore-latest-vc-go branch December 11, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants