Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Show the list of credentials which matches the submission #654

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

talwinder50
Copy link
Member

Current Behaviour: While selecting one from many credentials we were showing all stored credentials
Expected Behaviour: It should show only the list of credentials which matches the submission not all.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24981bb) 89.02% compared to head (7101deb) 88.97%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   89.02%   88.97%   -0.06%     
==========================================
  Files         102      102              
  Lines        4102     4101       -1     
==========================================
- Hits         3652     3649       -3     
- Misses        308      309       +1     
- Partials      142      143       +1     
Files Coverage Δ
pkg/did/wellknown/wellknown.go 89.79% <100.00%> (-0.59%) ⬇️
pkg/internal/issuermetadata/issuermetadata.go 75.00% <100.00%> (ø)
pkg/openid4vp/openid4vp.go 91.56% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolsonquadras rolsonquadras merged commit 4c25d64 into trustbloc:main Oct 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants