feat(app): Add support for custom scope in verfication flow #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talwinder50
force-pushed
the
claimsupport
branch
from
9a98651 to
1d61612
Compare
vkubiv
reviewed
Nov 13, 2023
demo/app/ios/Runner/OpenID4VP.swift
Outdated
| try initiatedInteraction.presentCredential(selectedCredentials) | ||
|
|
||
| if customScopes.count != 0 { | ||
| let opts2 = Openid4vpNewPresentCredentialOpts()?.addScopeClaim(customScopes.keys.first, claimJSON: (customScopes.values.first as! String)) |
There was a problem hiding this comment.
You need to add all custom scopes from customScopes: Dictionary
talwinder50
force-pushed
the
claimsupport
branch
from
1d61612 to
10b1040
Compare
vkubiv
approved these changes
Nov 14, 2023
talwinder50
force-pushed
the
claimsupport
branch
from
10b1040 to
c8a4e21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 89.09% 89.10% +0.01%
==========================================
Files 103 103
Lines 4146 4150 +4
==========================================
+ Hits 3694 3698 +4
Misses 308 308
Partials 144 144 ☔ View full report in Codecov by Sentry. |
talwinder50
force-pushed
the
claimsupport
branch
from
c8a4e21 to
5f1b8e7
Compare
Signed-off-by: Talwinder kaur <[email protected]>
talwinder50
force-pushed
the
claimsupport
branch
from
5f1b8e7 to
608d777
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Talwinder kaur [email protected]