Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecmascript): Proxy constract #528

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat(ecmascript): Proxy constract #528

merged 2 commits into from
Jan 16, 2025

Conversation

yossydev
Copy link
Contributor

It seems like test262 won’t pass without implementing Callable, so I’ll work on that first! #510 (comment)

ref: #160
doc: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-construct-argumentslist-newtarget

aapoalas
aapoalas approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me!

nova_vm/src/ecmascript/builtins/proxy.rs Show resolved Hide resolved
@yossydev
Copy link
Contributor Author

@aapoalas
Oh, you’ve reviewed it! Thank you!
I was planning to make it a draft until I added Callable, but is it okay if I go ahead and open it now?

aapoalas
aapoalas previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, let's merge this

@aapoalas aapoalas marked this pull request as ready for review January 15, 2025 16:00
@yossydev yossydev force-pushed the feat/proxy-constract branch from 861316a to c996b8c Compare January 16, 2025 00:57
@yossydev yossydev changed the title WIP: feat(ecmascript): Proxy constract WIPfeat(ecmascript): Proxy constract Jan 16, 2025
@yossydev yossydev changed the title WIPfeat(ecmascript): Proxy constract feat(ecmascript): Proxy constract Jan 16, 2025
@yossydev
Copy link
Contributor Author

I’ve resolved the conflict!

@aapoalas aapoalas merged commit 9e8c786 into trynova:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yossydev @aapoalas