allow external secrets to potentially clobber other secrets if opted in #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjlgao
reviewed
Jan 24, 2025
JatinNanda
force-pushed
the
jatin/allow-eso-to-specify-postgres-password
branch
3 times, most recently
from
0a6ec33 to
4633878
Compare
JatinNanda
force-pushed
the
jatin/allow-eso-to-specify-postgres-password
branch
from
4633878 to
6d7ddf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if external secrets are currently enabled, they don't let us specify the regular configuration secrets as a safeguard from clobbering.
this flag should let us both use an externalsecret for something like the postgres password and just use a regular secret for the other things like license key