Move segment attrs to lineage #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
==========================================
- Coverage 90.96% 90.96% -0.01%
==========================================
Files 20 20
Lines 12003 12032 +29
Branches 2444 2449 +5
==========================================
+ Hits 10919 10945 +26
- Misses 598 600 +2
- Partials 486 487 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jeromekelleher
force-pushed
the
move-segment-attrs-to-lineage
branch
2 times, most recently
from
542f634 to
7435ca9
Compare
Update the class definitions Remove unused hull argument msp_alloc_segment
Patch-up DTWF in python Patch up sweep code in Python Basic coalescent working in C Other basic models passing in C C code mostly working! Fixup python algorithms code
Finish moving population to Lineage in Python Get population on lineage working for C FIXUP python algorithms code fixup Pyhton c interface Tidy Python
jeromekelleher
force-pushed
the
move-segment-attrs-to-lineage
branch
from
d5933c1 to
be2644d
Compare
|
I'm going to merge this much as more progress on the refactoring for #2294. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2296