Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscribe button #30

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Nov 3, 2023

Probably best to review the second commit individually; the first one is a git revert of aaa04a4 so that the second one makes more sense.

The idea is that whenever the channelContainer element is updated (per a MutationObserver) we check to see if the handle has changed, and if so replace the subscribe/download buttons with new buttons.

@bbilly1 bbilly1 merged commit 5987707 into tubearchivist:master Nov 9, 2023
1 check passed
@bakkot bakkot deleted the update-subscribe-button branch November 9, 2023 15:31
@farcaller
Copy link
Contributor

farcaller commented May 1, 2024

Is this actually functional? Since this PR the dlButton.setAttribute('data-id', videoId) is gone, so no data-id is set on the button, but the sendDownload() still references it.

I've tried using the extension off the master branch and the button doesn't work for me.

Edit: While that seems broken it's only triggered through the code path that's only accessible when you're not logged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants