Fix NEC sampling if threads are involved #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
requested changes
Jul 26, 2024
cvonelm
force-pushed
the
fix-nec-sampling
branch
from
bf86f32 to
0e338dc
Compare
bmario
requested changes
Oct 22, 2024
ve_check_pid() only works for processes, not threads, so lo2s complained that it could not find the real NEC device id for those threads. Rewrite the code to use ve_sysfs_path_info(). This gives us the correct sysfs path for a NEC device id, so we dont have to find it using ve_check_pid().
cvonelm
force-pushed
the
fix-nec-sampling
branch
from
0e338dc to
1214201
Compare
bmario
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ve_check_pid() only works for processes, not threads, so lo2s complained that it could not find the real NEC device id for those threads.
Rewrite the code to use ve_sysfs_path_info(). This gives us the correct sysfs path for a NEC device id, so we dont have to find it using ve_check_pid().